Skip to content

Always emitting description property for response object. It's required - #436

Merged
Darrel (darrelmiller) merged 4 commits into
microsoft:vnextfrom
VitaliyKurokhtin:vvk/required
Dec 30, 2019
Merged

Always emitting description property for response object. It's required#436
Darrel (darrelmiller) merged 4 commits into
microsoft:vnextfrom
VitaliyKurokhtin:vvk/required

Conversation

@VitaliyKurokhtin

Copy link
Copy Markdown
Contributor

Right now if empty response is provided it will be serialized as empty object thus producing invalid spec.

@darrelmiller

Copy link
Copy Markdown
Member

:-) That's a creative solution to the required description.

Comment thread src/Microsoft.OpenApi/Models/OpenApiResponse.cs Outdated
@VitaliyKurokhtin

Copy link
Copy Markdown
Contributor Author

Well, spec doesn't say that it MUST be non-null value :)

@darrelmiller Darrel (darrelmiller) added this to the 1.2.0 milestone Dec 29, 2019
@darrelmiller
Darrel (darrelmiller) changed the base branch from master to vnext December 29, 2019 23:34
@darrelmiller
Darrel (darrelmiller) merged commit 06bc518 into microsoft:vnext Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants